Skip to content

[flake8-pyi] Make PYI032 example error out-of-the-box #19061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2025
Merged

[flake8-pyi] Make PYI032 example error out-of-the-box #19061

merged 2 commits into from
Jul 1, 2025

Conversation

MeGaGiGaGon
Copy link
Contributor

Summary

Part of #18972

This PR makes datetime-min-max (DTZ901)'s example error out-of-the-box

Old example

class Foo:
    def __eq__(self, obj: typing.Any) -> bool: ...

New example

from typing import Any


class Foo:
    def __eq__(self, obj: Any) -> bool: ...

Test Plan

N/A, no functionality/tests affected

@MeGaGiGaGon MeGaGiGaGon requested a review from AlexWaygood as a code owner July 1, 2025 00:55
@MeGaGiGaGon MeGaGiGaGon mentioned this pull request Jul 1, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@AlexWaygood AlexWaygood added the documentation Improvements or additions to documentation label Jul 1, 2025
@AlexWaygood AlexWaygood merged commit b8653a9 into astral-sh:main Jul 1, 2025
36 checks passed
@MeGaGiGaGon MeGaGiGaGon deleted the patch-5 branch July 1, 2025 07:25
iyakushev pushed a commit to iyakushev/ruff that referenced this pull request Jul 1, 2025
@MeGaGiGaGon @iyakushev
[flake8-pyi] Make PYI032 example error out-of-the-box (astral-sh#…
0aac2f1 
…19061)
@BrewTestBot BrewTestBot mentioned this pull request Jul 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MeGaGiGaGon @AlexWaygood