[flake8-simplify] Fix SIM911 autofix creating a syntax error
#18793
Conversation
|
|
I think this wouldn't work in all cases, since it's explicitly checking for My guess is the correct thing to do would be to use |
For that case it fixes with no issue --- sample2.py
+++ sample2.py
@@ -1,2 +1,2 @@
flag_stars = {}
-for country, stars in 1or(zip)(flag_stars.keys(), flag_stars.values()):...
+for country, stars in 1or flag_stars.items():...
Cool, didn't know that function. I'll try to update the solution. |
|
I think it worked there because there happened to be whitespace between the |
Should be fine now, I've updated to use |
| @@ -101,7 +102,11 @@ pub(crate) fn zip_dict_keys_and_values(checker: &Checker, expr: &ast::ExprCall) | |||
| return; | |||
| } | |||
|
|
|||
| let expected = format!("{}.items()", checker.locator().slice(var1)); | |||
| let expected = edits::pad( | |||
There was a problem hiding this comment.
Nice, I didn't know this existed
Summary
The fix would create a syntax error if there wasn't a space between the
inkeyword and the following expression.For example:
I also noticed that the tests for
SIM911were note being run, so I fixed that.Fixes #18776
Test Plan
Add regression test