[red-knot] Decompose bool to Literal[True, False] in unions and intersections (v2) #15773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sharkdp -- curious if you find this more or less easy to understand than #15738? The final commit here is the only difference between the two. (I'll add a comment to the branch about boolean literals delegating to Performance seems to be basically the same between the two. Maybe this one is a tiny bit slower? But it could just be noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An alternative to #15738, which might be slightly more readable and easier to reason about. I'm also curious to see how this compares with the Codspeed benchmarks.
Test Plan
Same tests as #15738