Reword future-rewritable-type-annotation (FA100) message
#11381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| FA100 | 12894 | 6447 | 6447 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+6447 -6447 violations, +0 -0 fixes in 2 projects; 42 projects unchanged)
apache/airflow (+27 -27 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ airflow/serialization/pydantic/dataset.py:51:12: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - airflow/serialization/pydantic/dataset.py:51:12: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` + airflow/serialization/pydantic/dataset.py:56:21: FA100 Add `from __future__ import annotations` to simplify `typing.List` - airflow/serialization/pydantic/dataset.py:56:21: FA100 Missing `from __future__ import annotations`, but uses `typing.List` + airflow/serialization/pydantic/dataset.py:57:22: FA100 Add `from __future__ import annotations` to simplify `typing.List` - airflow/serialization/pydantic/dataset.py:57:22: FA100 Missing `from __future__ import annotations`, but uses `typing.List` + airflow/serialization/pydantic/dataset.py:66:17: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - airflow/serialization/pydantic/dataset.py:66:17: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` + airflow/serialization/pydantic/dataset.py:68:21: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - airflow/serialization/pydantic/dataset.py:68:21: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` ... 44 additional changes omitted for project
zulip/zulip (+6420 -6420 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ analytics/lib/counts.py:105:23: FA100 Add `from __future__ import annotations` to simplify `typing.Type` - analytics/lib/counts.py:105:23: FA100 Missing `from __future__ import annotations`, but uses `typing.Type` + analytics/lib/counts.py:106:24: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - analytics/lib/counts.py:106:24: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` + analytics/lib/counts.py:106:68: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - analytics/lib/counts.py:106:68: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` + analytics/lib/counts.py:119:53: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - analytics/lib/counts.py:119:53: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` + analytics/lib/counts.py:183:49: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - analytics/lib/counts.py:183:49: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` + analytics/lib/counts.py:212:49: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - analytics/lib/counts.py:212:49: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` + analytics/lib/counts.py:306:15: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - analytics/lib/counts.py:306:15: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` + analytics/lib/counts.py:306:24: FA100 Add `from __future__ import annotations` to simplify `typing.Union` - analytics/lib/counts.py:306:24: FA100 Missing `from __future__ import annotations`, but uses `typing.Union` + analytics/lib/counts.py:314:14: FA100 Add `from __future__ import annotations` to simplify `typing.Dict` - analytics/lib/counts.py:314:14: FA100 Missing `from __future__ import annotations`, but uses `typing.Dict` + analytics/lib/counts.py:314:24: FA100 Add `from __future__ import annotations` to simplify `typing.Union` - analytics/lib/counts.py:314:24: FA100 Missing `from __future__ import annotations`, but uses `typing.Union` + analytics/lib/counts.py:315:20: FA100 Add `from __future__ import annotations` to simplify `typing.List` - analytics/lib/counts.py:315:20: FA100 Missing `from __future__ import annotations`, but uses `typing.List` + analytics/lib/counts.py:436:15: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - analytics/lib/counts.py:436:15: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` + analytics/lib/counts.py:436:24: FA100 Add `from __future__ import annotations` to simplify `typing.Tuple` - analytics/lib/counts.py:436:24: FA100 Missing `from __future__ import annotations`, but uses `typing.Tuple` + analytics/lib/counts.py:436:30: FA100 Add `from __future__ import annotations` to simplify `typing.Type` - analytics/lib/counts.py:436:30: FA100 Missing `from __future__ import annotations`, but uses `typing.Type` + analytics/lib/counts.py:470:19: FA100 Add `from __future__ import annotations` to simplify `typing.Type` - analytics/lib/counts.py:470:19: FA100 Missing `from __future__ import annotations`, but uses `typing.Type` + analytics/lib/counts.py:472:15: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - analytics/lib/counts.py:472:15: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` + analytics/lib/counts.py:472:24: FA100 Add `from __future__ import annotations` to simplify `typing.Tuple` - analytics/lib/counts.py:472:24: FA100 Missing `from __future__ import annotations`, but uses `typing.Tuple` + analytics/lib/counts.py:472:30: FA100 Add `from __future__ import annotations` to simplify `typing.Type` - analytics/lib/counts.py:472:30: FA100 Missing `from __future__ import annotations`, but uses `typing.Type` + analytics/lib/counts.py:475:73: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - analytics/lib/counts.py:475:73: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` + analytics/lib/counts.py:488:51: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - analytics/lib/counts.py:488:51: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` + analytics/lib/counts.py:523:69: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - analytics/lib/counts.py:523:69: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` + analytics/lib/counts.py:536:21: FA100 Add `from __future__ import annotations` to simplify `typing.Dict` - analytics/lib/counts.py:536:21: FA100 Missing `from __future__ import annotations`, but uses `typing.Dict` + analytics/lib/counts.py:536:26: FA100 Add `from __future__ import annotations` to simplify `typing.Tuple` - analytics/lib/counts.py:536:26: FA100 Missing `from __future__ import annotations`, but uses `typing.Tuple` + analytics/lib/counts.py:558:40: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` - analytics/lib/counts.py:558:40: FA100 Missing `from __future__ import annotations`, but uses `typing.Optional` + analytics/lib/counts.py:58:19: FA100 Add `from __future__ import annotations` to simplify `typing.Optional` ... 12791 additional changes omitted for project
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| FA100 | 12894 | 6447 | 6447 | 0 | 0 |
charliermarsh
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
future-rewritable-type-annotation(FA100) message to be less confusing. Uses phrasing from the rule documentation to be consistent. For example,Closes #10573.
Test Plan
cargo nextest run