Skip to content

feat: add emitIsolatedDts support #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2024
Merged

feat: add emitIsolatedDts support #270

merged 1 commit into from
Dec 4, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Aug 26, 2024 •
edited
Loading

Add experimental support for the jsc.experimental.emitIsolatedDts feature to output .d.ts instead of .js.

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@jbedard jbedard force-pushed the dts_outs branch 3 times, most recently from 002ac69 to 84b06f8 Compare August 27, 2024 00:14
@jbedard jbedard requested a review from alexeagle August 27, 2024 00:16
@jbedard jbedard marked this pull request as ready for review August 27, 2024 00:17
@jbedard jbedard requested a review from gregmagolan August 27, 2024 00:23
alexeagle
alexeagle approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, seems like an obvious next step

@jbedard jbedard marked this pull request as draft August 29, 2024 00:30
@jbedard
Copy link
Member Author

jbedard commented Aug 29, 2024

I think we're blocked for now on swc-project/swc#9512 if I'm understanding correctly. The way we invoke the cli using --out-file doesn't work with the swc cli atm.

@jbedard jbedard mentioned this pull request Dec 4, 2024
Merged
@jbedard jbedard force-pushed the dts_outs branch 3 times, most recently from 24709dc to aca890e Compare December 4, 2024 21:31
@jbedard jbedard marked this pull request as ready for review December 4, 2024 21:35
@jbedard jbedard merged commit 093f69b into main Dec 4, 2024
11 checks passed
@jbedard jbedard deleted the dts_outs branch December 4, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @alexeagle