process: sync commits from Aspect-internal silo #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3b178c4 to
cbe1108
Compare
### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: b978314e45722293228ca2ef20c185b696faf093
Synced from #814 by fzakaria: IntelliJ IDE uses a query with no arguments which seems to cause havoc when this is run via aspect. I added support to check for `--tool_tag` and not prompt the user for a query selection to better handle this usecase. Fixes #813 ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Support running queries via `--query_file` ### Test plan ``` > /Users/fzakaria/code/github.com/aspect-build/aspect-cli/bazel-bin/cmd/aspect/aspect_/aspect query --tool_tag=ijwb:IDEA:ultimate "--override_repository=intellij_aspect=/Users/fzakaria/Library/Application Support/JetBrains/IntelliJIdea2024.1/plugins/ijwb/aspect" --override_repository=intellij_aspect_template=/Users/fzakaria/code/github.com/confluentinc/ce-kafka/.ijwb/aspect --output=label_kind --keep_going --query_file=/Users/fzakaria/code/github.com/confluentinc/ce-kafka/.ijwb/queries/query-13438905584701813446 > echo $? 2 ``` Closes #814 Co-authored-by: Farid Zakaria <fzakaria@confluent.io> GitOrigin-RevId: bf38a5b5e7d9ace6eb7d7719887cde69fc125783
cbe1108 to
fbb7214
Compare
thesayyn
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/dfbd3b81900ac3af75967db5e9851e9716ed064c..b978314e45722293228ca2ef20c185b696faf093