-
Notifications
You must be signed in to change notification settings - Fork 36
process: sync commits from Aspect-internal silo #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
f47bd3e
to
ce20a63
Compare
…les_go (#7849) This is required for bazel-contrib/rules_go#4170 to allow upgrading x/tools to v0.27.0 - Covered by existing test cases GitOrigin-RevId: ee08e69fbb993ee22a0ef3a1ff28b594d23507c1
Fixes a variety of gazelle configuration errors. Most importantly fixes gazelle.check.sh to run from the workspace directory rather than the runfiles directory Fixed up all errors that weren't being caught as a result of lack of enforcement due to the above --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 1279be995a7e8e29bbf47d8c3f14074eb8290e54
Imports from .proto files should respect `js_ignore_imports` when generating `ts_proto_library(deps)` --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Support `js_ignore_imports` of .proto imports for `aspect configure`. ### Test plan - New test cases added GitOrigin-RevId: 725c538ed3a465c245cceec2bcff14a2adccc35f
### Changes are visible to end-users: no ### Test plan - Manual testing; please provide instructions so we can reproduce: CI on #808 GitOrigin-RevId: 2c5397e9ad7b7b7eb8caadc12c58b7f79963526c
…ry (#7859) ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Support aspect `configure` dependencies on generated `ts_proto_library` `_pb`, `_connect` and `_connectquery` files. GitOrigin-RevId: 8b3289a2161589f2a3e4499e888305214a12e501
- Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes See the latest new features in [gazelle 0.41](https://github.com/bazel-contrib/bazel-gazelle/releases/tag/v0.41.0) - Covered by existing test cases GitOrigin-RevId: 7d9343c3011d847b8e1298b538f2be43d77e6035
### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Add aspect `configure` `ts_project(declaration_dir)` support. ### Test plan - Covered by existing test cases - New test cases added GitOrigin-RevId: 79a0f852cea2c52f8a2e913c8a41ab27d1908eaa
…config related attribute generation (#7872) ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Add `# aspect:js_tsconfig_ignore {attribute}` to disable generation of tsconfig related `ts_project` attributes such as `tsconfig`, `declaration`, `incremental` etc. Use cases include scenarios where such attributes are automatically set by a macro or when such config is unnecessary within bazel but the underlying tsconfig.json can not be changed. ### Test plan - New test cases added GitOrigin-RevId: 7f441e37b0aeed266c6fc52041e40621493d4f29
Silo is red on main: - https://buildkite.com/aspect-build/silo-aws/builds/31645#0194a9eb-5d14-4feb-9b63-d21d0ed3c155 - https://buildkite.com/aspect-build/silo-gcp/builds/30923#0194a9ee-ba75-412c-8bd3-08660f592981 Ran `UPDATE_SNAPSHOTS=true bazel run //cli/core/gazelle/js:tsconfig_optout_test` to update the snapshot and green it up. --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 97d732433a9eeaefec1777de89184cade444482d
Per mdx-js/mdx#1049 this syntax has been removed as a breaking change in MDX v2. Using the replacement syntax unblocks a Docusaurus v3 upgrade, as it uses the newer MDX. Fixes autolinks, creates better link text, and fixes inline code issues --- --------- Co-authored-by: Chris Chinchilla <chris@aspect.build> GitOrigin-RevId: 23290d570da933ad590e7b172331819c6acf3b5c
…#7934) While looking into tree-sitter performance I realized we can do a few things: * use the `[...]` operator (similar to regex) to merge the esm + cjs queries * use the `.` anchor operator to only match the first argument, so we won't be iterating over all string arguments anymore --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes `aspect configure` AST query performance improvements ### Test plan - Covered by existing test cases - New test cases added GitOrigin-RevId: d1d34ba29c564ae107895f32c7f3760011668ce4
See the example in the test: a dts file that package.json references but is not within the `ts_project(srcs)`. --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Fix `aspect configure` to allow generated package targets to include source files not included in `ts_project(srcs)` ### Test plan - New test cases added GitOrigin-RevId: cd05a1a7285f04e99a2ae41b011b261ea0a9359f
This contains some bzlmod + bazel8 fixes, see the patch diff. --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases Co-authored-by: Sahin Yort <thesayyn@gmail.com> GitOrigin-RevId: 5f9a87813ec237d8dcaf4af9922ca8d612564309
Interactive mode in the Aspect CLI does not work when Aspect CLI hints are enabled (added in [2025.03.28](https://docs.aspect.build/cli/releases#20250328) #7813). This change fixes that by limited the hints stdout & stderr streams --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Aspect CLI hints feature now only parses the stdout & stderr from Bazel out in the following commands: build, coverage, fetch, info, lint, run, test. This fixes interactive mode in the CLI when hints are enabled. ### Test plan - Covered by existing test cases - Manual testing; please provide instructions so we can reproduce: Try interactive mode with hints enabled. Verify that hints work in the commands build, coverage, fetch, info, lint, run, test for cli pro and oss builds. GitOrigin-RevId: 36b9b384e12c29f9ba9853be6a4976d2bcf5b3ca
I will profile this more later but this fixes a bug and adds tests for now. --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Fix issue detecting dependencies in dynamic import/require calls containing a nested comment such as `/* webpackChunkName: ... */`. Example repro: https://github.com/walkerburgin/aspect-cli-regression-repro ### Test plan - New test cases added GitOrigin-RevId: 408cfe4abb99f4c5b4b45e0fd7984a359fa978f7
Fixes stdout & stderr flushing when hints are enabled. Also adds a way to disable hints the flag `--aspect:hints=false` or `--aspect:hints=0` --- - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Fixes stdout & stderr flushing when hints are enabled. Also adds a way to disable hints the flag `--aspect:hints=false` or `--aspect:hints=0`. - New test cases added - Manual testing; please provide instructions so we can reproduce: Tested that flushing works manually with `bazel run -- terraform apply` that prompts with a yes/no question. This was previously broken. Also tested manually that Linjie's repro is fixed: https://aspect-build.slack.com/archives/C05S94VJWNM/p1738609744534369?thread_ts=1738164769.873979&cid=C05S94VJWNM. GitOrigin-RevId: d2183eb3fc5b8f328c1b00bad29e1461aae3c241
…d (#8035) Additional fix after #8028. Simpler and more correct to just forward byte-for-byte the bytestream and leave the higher-lever processing for the side-channel hints detection only. --- ### Changes are visible to end-users: no The bug this fixes hasn't been released yet so it does not impact users. ### Test plan - Covered by existing test cases - Manual testing; please provide instructions so we can reproduce: Tested that flushing works manually with `bazel run -- terraform apply` that prompts with a yes/no question. Tested that hints work as expected. GitOrigin-RevId: 25667cae2701b892e902e51f302645e4278a8e1e
pnpm up --latest Reverted back to react / react dom v18 since fluent UI currently breaks in weird ways under v19 The upgrade required the following migrations - Remove google.api.field_behavior annotations from protobufs which need ts_proto_library. They aren't incompatible, but the amount of silo infrastructure that would need to change doesn't justify the benefit of the annotation - Upgrade to bufbuild/protobuf version 2 needed migration see https://buf.build/blog/protobuf-es-v2 - Upgrade to latest webpack version required a migration to ecmascript modules. - Since we are running node version 17 (we need to fix this), I'm forced to add `.js` as a suffix to my imports when running in node processes and using ecmascript modules. I also need to polyfill the fetch API since bufbuid/connect dropped support for node v17 --- - Covered by existing test cases GitOrigin-RevId: 9e48bae7127ea9ada4cdcb9b5d65a0e82f4a5bde
Synced from #810 by walkerburgin: --- Small quality of life improvement to stop logging a warning on `null` subpath exports in `package.json`: ```json { "exports": { "./features/*.js": "./src/features/*.js", "./features/private-internal/*": null } } ``` --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Do not output `aspect configure` warning for package.json 'null exports' ### Test plan - Covered by existing test cases - Manual testing; please provide instructions so we can reproduce: Closes #810 Co-authored-by: Walker Burgin <wburgin@anduril.com> GitOrigin-RevId: e4d41609ed4bf14f13d6b975a9df023558a0d9be
For example: generating test targets that depend on .js files, see the new test. --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Support orion plugins importing and depending on js language files such as those outputted by generated `ts_project` targets. ### Test plan - New test cases added GitOrigin-RevId: ddbfb59a86aa8c1eced969e99c9d2de67a84f698
… (#8089) I missed updating the lint BES handling to be multi-threaded when I made the change in the Workflows plugin. Handling this now as Airtable reported that their lint task on some builds has 1m+ of waiting for BES upload. This should resolve that. --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes (oss) Aspect CLI lint command now handle multi-threaded BES events for faster BES processing ### Test plan - Covered by existing test cases - Manual testing; please provide instructions so we can reproduce: Vendored Aspect CLI for a CI run: https://buildkite.com/aspect-build/silo-aws/builds/32649#0195028c-9832-4e55-a05b-1c5634f7111f Ran `bazel-bin/cli/pro/pro_/pro lint //cli/...` locally on MacOS GitOrigin-RevId: f37553c15a6ae74d08da8c38192044650d66061f
Requested by Physical Intelligence: https://aspect-build.slack.com/archives/C07TEJ68FAN/p1739464567808589?thread_ts=1739421828.215809&cid=C07TEJ68FAN --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes (OSS) Aspect CLI configure command now supports hints ### Test plan - Covered by existing test cases - Manual testing; please provide instructions so we can reproduce: Manually test hints on configure command GitOrigin-RevId: e345423ae9370136025369d914ab0b5274cf92a2
Formatting was off for long lines. This fixes it so we don't box the lines in anymore: ``` ┌ | Aspect CLI | | - This is a multi-line | hint! | | - This is a hint └ ``` Physical Intelligence mentioned it here: https://aspect-build.slack.com/archives/C07TEJ68FAN/p1739464922264439?thread_ts=1739421828.215809&cid=C07TEJ68FAN --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes (OSS) Fix formatting of long lines in Aspect CLI hints output ### Test plan - Covered by existing test cases GitOrigin-RevId: 232e10e5e56ad5596ca48e320f9c74dbbb7e655a
…#8122) This reverts commit e345423ae9370136025369d914ab0b5274cf92a2. Turns out gazelle and gazelle plugins call `log.Fatal` and `os.Exit` which makes them incompatible with hints :( --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 7c3bef4eea8f845cbc2a0b7a015ce6fe9001e232
The is the gazelle API added to support bzlmod support for things like the `repo_name` attribute, or the fact that ruleset names on the bzlmod registry are often different then the conventional names put into repository rules (like `http_archive`). See the gazelle and rules_go language change: bazel-contrib/bazel-gazelle@a9fdc5e --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Support bzlmod module naming. ### Test plan - Covered by existing test cases - New test cases added GitOrigin-RevId: dfbd3b81900ac3af75967db5e9851e9716ed064c
ce20a63
to
4e5c8b3
Compare
thesayyn
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/d9eb92d2924a59edf2c42f9c342a1c9b1873e7c6..ee08e69fbb993ee22a0ef3a1ff28b594d23507c1