Skip to content

docs: add note about fetching tags during release #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

docs: add note about fetching tags during release #767

merged 1 commit into from
Nov 6, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Oct 30, 2024

So I don't forget next time...

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@jbedard jbedard requested a review from alexeagle October 30, 2024 17:56
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Oct 30, 2024 •
edited
Loading

Test

All tests were cache hits

208 tests (100.0%) were fully cached saving 9m 31s.

Buildifier      Format

@jbedard
Copy link
Member Author

jbedard commented Oct 30, 2024

FWIW the issue prompting this was me tagging + pushing a release without first doing git fetch --tags first. So the generated locally was not up to date, but the tag generated by CI for the binaries (but not the release notes) was correct (see #766).

Why does CI generate the tag again? I'm not sure if that's worth investigating or fixing now, but fyi.

@jbedard jbedard requested a review from gregmagolan October 30, 2024 18:01
@jbedard jbedard mentioned this pull request Oct 30, 2024
Closed
@alexeagle alexeagle merged commit d161c8f into main Nov 6, 2024
11 checks passed
@alexeagle alexeagle deleted the releasing-tags branch November 6, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @alexeagle