Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aspect-build/aspect-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2024.39
Choose a base ref
...
head repository: aspect-build/aspect-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2024.39.8
Choose a head ref
  • 8 commits
  • 53 files changed
  • 3 contributors

Commits on Sep 28, 2024

  1. refactor(cli): align aspect configure gitignore feature with proposed… 

    … gazelle feature implementation (#6873)

This aligns the implementation more with what I'm trying to merge into
gazelle: bazel-contrib/bazel-gazelle#1908

There are no user facing changes here but the implementation is simpler
and should improve performance for many reasons:
* the .gitignore files are only `os.Open`ed once per directory (not per
directory * per language)
* the .gitignore files are only parsed once instead of once per gazelle
language
* the .gitignore patterns are only executed once because it is done
within the (patched) gazelle walk
* .gitignore-d directories are not recursed into at all because they are
filtered in the gazelle fs walk
* ...

---

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

GitOrigin-RevId: 27fe8377ca89de91d3c95105ab37adea9347e6ab
    @jbedard
    jbedard committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    a70f957 View commit details
    Browse the repository at this point in the history

  2. fix: disable python extension on windows (#6879) 

    ### Changes are visible to end-users: yes

- Searched for relevant documentation and updated as needed: yes
- Breaking change (forces users to change their own code or config): no
- Suggested release notes appear below: yes

Disable python extension on windows

### Test plan

- Covered by existing test cases

GitOrigin-RevId: 631b85f43769ea877ebd14d6b4df7be48077dd64
    @thesayyn @jbedard
    thesayyn authored and jbedard committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    a2d1a0b View commit details
    Browse the repository at this point in the history

  3. fix(cli): support js_ignore_imports for package.json imports (#6926) 

    The package.json deps should support the same `js_ignore_imports`
directive as all other js imports.

Ideally this will move to a more common location but this is the quick
fix.

---

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases
- New test cases added

GitOrigin-RevId: cfa2a62823454674453f3d6458e52ed30fbe0581
    @jbedard
    jbedard committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    6af1457 View commit details
    Browse the repository at this point in the history

  4. chore: remove homebrew from release artifacts and switch to monorepo … 

    …versioning
    @gregmagolan
    gregmagolan committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    af217bd View commit details
    Browse the repository at this point in the history

  5. chore: update release instructions for new versioning scheme

    @gregmagolan
    gregmagolan committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    973cc74 View commit details
    Browse the repository at this point in the history

  6. chore: fix release GitHub action trigger

    @gregmagolan
    gregmagolan committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    cbf66d4 View commit details
    Browse the repository at this point in the history

  7. README fixes

    @gregmagolan
    gregmagolan committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    012477c View commit details
    Browse the repository at this point in the history

  8. chore: fetch full history for release step

    @gregmagolan
    gregmagolan committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    9f51b28 View commit details
    Browse the repository at this point in the history
Loading