Skip to content

Restore support for null-valued maps when ignoring fields #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2025
Merged

Restore support for null-valued maps when ignoring fields #3723

merged 1 commit into from
Jan 3, 2025

Conversation

scordio
Copy link
Member

@scordio scordio commented Jan 2, 2025 •
edited
Loading

@scordio scordio added this to the 3.27.2 milestone Jan 2, 2025
@scordio scordio linked an issue Jan 2, 2025 that may be closed by this pull request
ignoringFields on recursive comparison no longer works with maps with null values #3722
Closed
@scordio scordio changed the base branch from 3.x to main January 3, 2025 07:46
@scordio scordio changed the base branch from main to 3.x January 3, 2025 08:04
@scordio scordio merged commit d7df2d7 into 3.x Jan 3, 2025
21 checks passed
@scordio scordio deleted the gh-3722-map-with-null-values branch January 3, 2025 08:30
@scordio scordio restored the gh-3722-map-with-null-values branch January 3, 2025 08:40
@scordio scordio mentioned this pull request Jan 3, 2025
Merged
@scordio scordio removed a link to an issue Jan 3, 2025
ignoringFields on recursive comparison no longer works with maps with null values #3722
Closed
@scordio scordio linked an issue Jan 3, 2025 that may be closed by this pull request
ignoringFields on recursive comparison no longer works with maps with null values #3722
Closed
@scordio scordio deleted the gh-3722-map-with-null-values branch January 3, 2025 09:10
@scordio
Copy link
Member Author

scordio commented Jan 4, 2025

BTW credits go to @amaembo for the inspiration at https://stackoverflow.com/a/32649053/9714611!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joel-costigliola joel-costigliola Awaiting requested review from joel-costigliola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.27.2
Development

Successfully merging this pull request may close these issues.

ignoringFields on recursive comparison no longer works with maps with null values
1 participant
@scordio