Skip to content

Propagate common basetype for extracting(Function...) #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2024
Merged

Propagate common basetype for extracting(Function...) #3673

merged 1 commit into from
Nov 23, 2024

Conversation

patrickuhlmann
Copy link
Contributor

@patrickuhlmann patrickuhlmann commented Nov 23, 2024 •
edited by scordio
Loading

before it was always Object. This resolves #3372.

Co-authored-by: IvoHD <IvoHD@users.noreply.github.com>
Co-authored-by: Alexandra Junghans <alexandra-junghans@users.noreply.github.com>
Co-authored-by: Mahmoud Ben Hassine <fmbenhassine@users.noreply.github.com>

@patrickuhlmann
propagate common basetype for the extracting method
8cfd0ce 
before it was always Object. This addresses assertj#3372.
@scordio scordio self-assigned this Nov 23, 2024
@scordio scordio added this to the 3.27.0 milestone Nov 23, 2024
@scordio scordio changed the title propagate common basetype for the extracting method Propagate common basetype for the extracting method Nov 23, 2024
@scordio scordio merged commit 588d24b into assertj:3.x Nov 23, 2024
11 checks passed
@scordio scordio changed the title Propagate common basetype for the extracting method Propagate common basetype for extracting(Function...) Nov 23, 2024
scordio added a commit that referenced this pull request Nov 24, 2024
@scordio
Polish contribution
5389d2a 
See #3673
@scordio scordio mentioned this pull request Dec 21, 2024
Closed
This was referenced Jan 6, 2025
Closed
Closed
scordio added a commit that referenced this pull request Jan 9, 2025
@scordio
Revert "Propagate common basetype for the extracting method (#3673)"
4d254b3 
This partially reverts 588d24b.
scordio added a commit that referenced this pull request Jan 9, 2025
@scordio
Revert "Propagate common basetype for the extracting method (#3673)"
5ea78e9 
This partially reverts 588d24b.
scordio added a commit that referenced this pull request Jan 9, 2025
@scordio
Revert "Propagate common basetype for the extracting method (#3673)"
f222fec 
This partially reverts 588d24b.
scordio added a commit that referenced this pull request Jan 10, 2025
@scordio
Revert "Propagate common basetype for the extracting method (#3673)"
a24672b 
This partially reverts 588d24b.
scordio added a commit that referenced this pull request Jan 11, 2025
@scordio
Revert "Propagate common basetype for the extracting method (#3673)"
5bac04b 
This partially reverts 588d24b.
scordio added a commit that referenced this pull request Jan 11, 2025
@scordio
Revert "Propagate common basetype for the extracting method (#3673)" (
79b87f0 
#3737)

This partially reverts 588d24b.
@scordio scordio added the event: Hack.Commit.Push A topic worked on during a Hack.Commit.Push event label Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scordio scordio

Labels
event: Hack.Commit.Push A topic worked on during a Hack.Commit.Push event
Projects
None yet
Milestone
3.27.0
Development

Successfully merging this pull request may close these issues.

extracting(Function...) propagates Object instead of the common base type of all extractors
2 participants
@patrickuhlmann @scordio