Add completesExceptionallyWithin to CompletableFuture assertions
#3597
Conversation
|
Thanks @vladykin, I'll review the PR this week end. |
|
Fixed code formatting that spotless plugin was complaining about |
|
Things that I wasn't sure about and haven't yet included:
|
|
@joel-costigliola, any feedback on this PR? |
|
I'll have a look this week |
|
commented thanks @vladykin |
|
@joel-costigliola, I don't see any comments here. Where can I find them? I see some failed CI jobs, but there are no details besides "This job failed", so I don't know what to do, and whether it's related to my PR or not. |
| import org.assertj.core.error.BasicErrorMessageFactory; | ||
| import org.assertj.core.error.ErrorMessageFactory; | ||
|
|
||
| public class ShouldHaveCompletedExceptionallyWithin extends BasicErrorMessageFactory { |
There was a problem hiding this comment.
add a unit test for this, like ShouldHaveCompletedExceptionally_create_Test
| } catch (@SuppressWarnings("unused") InterruptedException e) { | ||
| // do nothing | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's move these two methods in a FutureTestHelper class and replace their use in CompletableFutureAssert_failsWithin_Test
|
My bad I did confirm my review so my comments were pending |
|
the issues are not related to your PR, I reran the ubuntu job and it succeeded so all good |
|
Thanks for the comments, addressed |
|
Integrated thanks @vladykin ! |
completesExceptionallyWithin to CompletableFuture assertions
Issue #3587
Check List: