Skip to content

Produce both filled and unfilled files? #24

@sipa

Description

@sipa

Unsure if this is the right place to discuss/report, but I want to write it up so it isn't forgotten.

I notice that for the latest collaboratively-produced asmap file, the output was switched to use the --fill option to asmap-tool.py to produce a smaller binary. I think it makes sense that the eventually-included dump in the Bitcoin Core binary is a filled one, but for auditing purposes it is probably better that the collaboratively-produced file isn't, so the ability to compare/inspect isn't hurt by the filling.

Note that it's possible to perform the filling step afterwards, converting an unfilled binary .dat file to a filled one (asmap-tool.py encode --fill asmap_unfilled.dat asmap_filled.dat) without needing the original text format data. I also believe that the conversion is deterministic (as long as the asmap-tool.py encoding algorithm doesn't change) so with the same unfilled .dat file one would be able to recreate the same corresponding filled one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions