Better support for mocking methods like std::io::Read::read #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::io::Read::read is often called with an uninitialized buffer as its argument. So Mockall shouldn't try to read from that buffer, even though the language rules allow it to. Previously, Mockall would try to read from it, in order to format a panic message in case no matching Expectation was found. Now, Mockall will not try to format such a panic message preemptively. It will only do it if there actually isn't any matching Expectation. That also provides a small performance boost to all users. Also, do a better job of clearing poison from static methods' Mutexes following a panic. Previously we would only do that if the user had created a Context object. Now we will do it regardless. Fixes #647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::io::Read::read is often called with an uninitialized buffer as its argument. So Mockall shouldn't try to read from that buffer, even though the language rules allow it to. Previously, Mockall would try to read from it, in order to format a panic message in case no matching Expectation was found.
Now, Mockall will not try to format such a panic message preemptively. It will only do it if there actually isn't any matching Expectation. That also provides a small performance boost to all users.
Also, do a better job of clearing poison from static methods' Mutexes following a panic. Previously we would only do that if the user had created a Context object. Now we will do it regardless.
Fixes #647