Add v2 version support for makezero module #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with version 2.x need support to pull module, ``` go get -u github.com/ashanbrown/makezero/v2 ``` Even pkg docs points v1.2.0 https://pkg.go.dev/github.com/ashanbrown/makezero Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
|
@ashanbrown Need v2 reference for the module so that it fits into go module versioning. |
|
@ashanbrown Can you please take look at PR whenever you get chance ? Sorry for troubles |
|
Just for reference, it looks like I failed to follow the v2 release policy detailedat https://go.dev/wiki/Modules#releasing-modules-v2-or-higher. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with version 2.x need support to pull module,
Even pkg docs points v1.2.0 https://pkg.go.dev/github.com/ashanbrown/makezero