Skip to content

Conversation

gertd
Copy link
Member

@gertd gertd commented Apr 16, 2025

Fix topaz template install using a custom template, which does not use ghcr.io.

  • Extract the policy registry from the resource passed in, instead of using the hardcoded https://ghcr.io
  • Fallback to use ghcr.io when the extraction fails

With this change, existing templates continue to work, all template tests pass, and no updates are required.

The complete fix requires adding a policy registry field, which will require updating all existing templates as well.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14498716528

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 14496599189: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@gertd gertd requested a review from ronenh April 16, 2025 17:37
@gertd gertd merged commit 09e9fbe into main Apr 16, 2025
5 checks passed
@gertd gertd deleted the fix-template-install-custom branch April 16, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants