Skip to content

Resolver update 2 #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 11, 2025
Merged

Resolver update 2 #588

merged 6 commits into from
Apr 11, 2025

Conversation

gertd
Copy link
Member

@gertd gertd commented Apr 11, 2025

Update the ServiceTypes interface, remove Cleanups, add Close()

package builder

type ServiceTypes interface {
	AvailableServices() []string
	GetGRPCRegistrations(services ...string) GRPCRegistrations
	GetGatewayRegistration(port string, services ...string) HandlerRegistrations
	Close()
}

and the resulting changes need to make this change.

@gertd gertd mentioned this pull request Apr 11, 2025
Closed
@coveralls
Copy link

coveralls commented Apr 11, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14403022659

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 14395480212: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

@gertd gertd changed the base branch from resolver-update to main April 11, 2025 12:20
@gertd gertd requested review from carabasdaniel and ronenh and removed request for carabasdaniel April 11, 2025 12:37
@carabasdaniel carabasdaniel merged commit 9c3d994 into main Apr 11, 2025
5 checks passed
@carabasdaniel carabasdaniel deleted the resolver-update-2 branch April 11, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronenh ronenh Awaiting requested review from ronenh

1 more reviewer

@carabasdaniel carabasdaniel carabasdaniel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gertd @coveralls @carabasdaniel