Skip to content

PromptYesNo handle os.Signal #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

PromptYesNo handle os.Signal #580

merged 1 commit into from
Apr 4, 2025

Conversation

gertd
Copy link
Member

@gertd gertd commented Apr 4, 2025

Change the PromptYesNo implementation to handle os.Signal, terminating the input loop when Ctrl+C or SIGTERM is received. The previous implementation would not stop until the y or n input was received.

@gertd gertd requested review from ronenh and carabasdaniel April 4, 2025 03:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14257237066

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 14252226806: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

@gertd gertd merged commit babacfc into main Apr 4, 2025
5 checks passed
@gertd gertd deleted the PromptYesNoSignal branch April 4, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronenh ronenh Awaiting requested review from ronenh

1 more reviewer

@carabasdaniel carabasdaniel carabasdaniel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gertd @coveralls @carabasdaniel