windows: Don't add an extra whitespace at end of Windows command line #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The windows code adds an unnecessary extra space to the command line. This can cause subtle issues, so avoid it.
laanwj
added a commit
to laanwj/bitcoin
that referenced
this pull request
May 20, 2025
laanwj
added a commit
to laanwj/bitcoin
that referenced
this pull request
May 20, 2025
arun11299
approved these changes
May 20, 2025
|
Thank you. |
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
May 20, 2025
The windows code adds an unnecessary extra space to the command line. This can cause subtle issues, so avoid it. Add missing error check for fcntl(fd, F_GETFD, 0) in set_clo_on_exec. Raise OSError on failure to align with existing FD_SETFD behavior. This improves robustness in subprocess setup and error visibility. Github-Pull: arun11299/cpp-subprocess#119 Rebased-From: 777cfa77d1f84bb08b3e445d5f7fc6c87282223b
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
May 20, 2025
The windows code adds an unnecessary extra space to the command line. This can cause subtle issues, so avoid it. Github-Pull: arun11299/cpp-subprocess#119 Rebased-From: 777cfa77d1f84bb08b3e445d5f7fc6c87282223b
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
May 20, 2025
The windows code adds an unnecessary extra space to the command line. This can cause subtle issues, so avoid it. Github-Pull: arun11299/cpp-subprocess#119 Rebased-From: 777cfa77d1f84bb08b3e445d5f7fc6c87282223b
laanwj
added a commit
to laanwj/bitcoin
that referenced
this pull request
May 20, 2025
fanquake
added a commit
to bitcoin/bitcoin
that referenced
this pull request
May 21, 2025
e63a703 subprocess: Don't add an extra whitespace at end of Windows command line (laanwj) Pull request description: A list of the backported PRs: - arun11299/cpp-subprocess#119 The following PRs were skipped for backporting: - arun11299/cpp-subprocess#118 because there is no changes in the header code. Required for #32566. ACKs for top commit: laanwj: Code review ACK e63a703 Tree-SHA512: 69a74aa7f9c611a9ec910e27161c5e9e147067d37f8335953cd3875fcc88dc840a2f7b206bb603f22507159e406b1449f1dc4702fffe890bb824672641b4feed
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 6, 2025
The windows code adds an unnecessary extra space to the command line. This can cause subtle issues, so avoid it. Github-Pull: arun11299/cpp-subprocess#119 Rebased-From: 777cfa77d1f84bb08b3e445d5f7fc6c87282223b Github-Pull: bitcoin#32567 Rebased-From: e63a703
saikiran57
pushed a commit
to saikiran57/bitcoin
that referenced
this pull request
Jul 28, 2025
The windows code adds an unnecessary extra space to the command line. This can cause subtle issues, so avoid it. Github-Pull: arun11299/cpp-subprocess#119 Rebased-From: 777cfa77d1f84bb08b3e445d5f7fc6c87282223b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows code adds an unnecessary extra space to the command line. This can cause subtle issues, so avoid it.