fix(my-collection): fixes image browser layout #15987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e99f2b to
a31e0c7
Compare
dzucconi
commented
Aug 12, 2025
| @@ -31,12 +31,10 @@ export const MyCollectionArtworkImageBrowser: React.FC< | |||
| } | |||
|
|
|||
| return ( | |||
| <Flex mb={[1, 0]}> | |||
#3869 Bundle Size — 9.33MiB (~+0.01%).efc16e2(current) vs 0a010e0 main#3865(baseline) Warning Bundle contains 36 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch DIA-1444-my-collection-image-gal... Project dashboard Generated by RelativeCI Documentation Report issue |
340e1bf to
efc16e2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obvious annoyance noticed when using the product this weekend. The gallery would start collapsed with overlapping arrows while the image loads. Then different sized images would shift around the content.
It's funny to me how almost every layout bug falls out of someone not obeying the golden rule
Also switched this to use Force's
TopContextBarfor consistency.cc @artsy/diamond-devs