Spaces around .. and ..<
#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although NEP1 suggests not having spaces around these infix operators, this creates an exception to the normal infix spacing rules. In spite of this recommendation, lots of code out there maintains spaces around the operators which makes decision based on "existing practice" hard. Adding to the complexity is in order to not break the AST, the code must take care to remove the spaces only in cases where the infix is not followed by another operator - this means that we _sometimes_ will put spaces around these infixes and sometimes not, again leading to irregularity. Since there's no consensus in existing code, the rule is irregular and causes implementation complexity, this PR removes the exception and formats `..` and `..<` with spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although NEP1 suggests not having spaces around these infix operators, this creates an exception to the normal infix spacing rules.
In spite of this recommendation, lots of code out there maintains spaces around the operators which makes decision based on "existing practice" hard.
Adding to the complexity is in order to not break the AST, the code must take care to remove the spaces only in cases where the infix is not followed by another operator - this means that we sometimes will put spaces around these infixes and sometimes not, again leading to irregularity.
Since there's no consensus in existing code, the rule is irregular and causes implementation complexity, this PR removes the exception and formats
..and..<with spaces.