Use serialize.h::VarInt for encoding #1
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's what I've been thinking of... It has two main differences: it encodes the type as a delta, which enforces a canonical encoding (lowest types go first), and it's slightly more compressed.
I think what you've currently got encodes:
[0, 2**14)
, length(value) = 1,2,3 -- 2 bytes + length(value)[0, 2**14)
, length(value) = 0 or [4,253] -- 3 bytes + length(value)I guess I find the "enforce canonical ordering by encoding as types as a delta" the most compelling part.
I found the
RecordLowerBitMask
stuff hard to follow as it's currently explained, fwiw....
Alternatively, perhaps doing a custom encoding with VarInt would be both clear and fine:
So your encoding is always:
That's still pretty compressed, and gives a canonical encoding/ordering...