add get-version command
#116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has to be different when reading from serial to check the version and when uploading the firmware.
per1234
requested changes
Sep 28, 2021
Co-authored-by: per1234 <accounts@perglass.com>
per1234
requested changes
Sep 30, 2021
Co-authored-by: per1234 <accounts@perglass.com>
silvanocerza
approved these changes
Sep 30, 2021
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 11.49% 11.04% -0.46%
==========================================
Files 18 21 +3
Lines 1722 1793 +71
==========================================
Hits 198 198
- Misses 1466 1537 +71
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a new sub-command to be able to retrieve the firmware version in use by a module.
During the process, I refactored a bit the code, since there were useless repetitions.
Docs have been added