Skip to content

Conversation

ardalis
Copy link
Owner

@ardalis ardalis commented May 16, 2024

Fixes #181
Make ErrorList correlationId optional
Allow Result.Error to take a single error message string

ardalis added 2 commits May 16, 2024 14:03
Allow Result.Error to take a single error message string
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Ardalis.Result 82% 95% 109
Summary 82% (193 / 234) 95% (36 / 38) 109

@ardalis ardalis merged commit b28ce95 into main May 16, 2024
@lloydkevin
Copy link

Questions:

  • Was the intent to replace the method taking params string[] errorMessages or should it have remain and delegate to the new method?

  • Is a similar change needed on all the others? (NotFound, Unauthorized, etc.)?

@ardalis
Copy link
Owner Author

ardalis commented Oct 16, 2024

Probably both methods should still exist (single string as well as string array) and yeah probably across the board. If you have time do you want to create an issue for this and perhaps a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional CorrelationId on ErrorList
2 participants