Skip to content

Publish the release version of the nuget packages #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

Publish the release version of the nuget packages #131

merged 1 commit into from
Apr 21, 2023

Conversation

thomas-mullaly
Copy link
Contributor

Forgot this argument, so the pack command was trying to pack debug assemblies. This should probably be it for me an PRs on this repo today 😅

To make sure this actually works, I did this locally:

dotnet clean
dotnet build --configuration Release
dotnet pack --no-build src/Ardalis.Result/Ardalis.Result.csproj --configuration Release --output nuget
dotnet pack --no-build src/Ardalis.Result.FluentValidation/Ardalis.Result.FluentValidation.csproj --configuration Release --output nuget
dotnet pack --no-build src/Ardalis.Result.AspNetCore/Ardalis.Result.AspNetCore.csproj --configuration Release --output nuget

and all the pack commands succeeded. apologies for all the CI noise.

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Ardalis.Result.SampleMinimalApi 69% 100% 2 ➖
Ardalis.Result 27% 18% 64 ❌
Ardalis.Result.AspNetCore 7% 5% 126 ❌
Ardalis.Result.Sample.Core 25% 29% 50 ❌
Ardalis.Result.FluentValidation 0% 0% 6 ❌
Summary 20% (123 / 620) 11% (16 / 140) 248 ❌

@ardalis ardalis merged commit 8f1416c into ardalis:main Apr 21, 2023
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
This was referenced Aug 5, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@dependabot dependabot bot mentioned this pull request Aug 18, 2025
Open
This was referenced Sep 3, 2025
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomas-mullaly @ardalis