Improve search validator and in-memory evaluator. #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardalis
reviewed
Mar 2, 2025
|
|
||
| private IEnumerator<TSource>? _enumerator; | ||
|
|
||
| public SpecLikeIterator(IEnumerable<TSource> source, List<SearchExpressionInfo<TSource>> searchExpressions) |
There was a problem hiding this comment.
Not switching to primary constructor syntax yet?
There was a problem hiding this comment.
I've been hesitant because of the older TFMs. We need to check whether we need any polyfills or not (I assume not).
| { | ||
| if (_searchExpressions is null) | ||
| { | ||
| _searchExpressions = new(2) { searchExpression }; |
There was a problem hiding this comment.
Replace magic number 2 with meaningful named constant?
There was a problem hiding this comment.
This represents the initial capacity. And it can be different for each collection, for example we may choose for Where to be 4, for Search 2, etc. We need to introduce 6-7 constants, and not sure whether that makes it better or worse.
There was a problem hiding this comment.
Updated to use constants.
This was referenced Jul 21, 2025
Closed
Closed
This was referenced Jul 29, 2025
This was referenced Sep 2, 2025
Bump Ardalis.Specification.EntityFrameworkCore from 8.0.0 to 9.3.1
AdrianLozanoMartinez/eShopOnWeb#5
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #421
Fixes #422
Fixes #424
SearchValidatorto allocation-free implementation. For larger input collections, the difference is drastic. For 1000 entities, the allocations are reduced from 651.160 bytes to ZERO bytes.SeatchMemoryEvaluatorand decreased allocations (constant allocation size regardless of input). Added custom iterator implementation. For larger input collections, the difference is drastic. For a source of 1000 items, the allocations are reduced from 257.872 bytes to only 56 bytes (the cost of the custom iterator instance).