Skip to content

Rename TagWithEvaluator to QueryTagEvaluator #515

@fiseni

Description

@fiseni

In version 9, we've added the TagWith feature. The state is sensibly called QueryTags.
However, we naively called the evaluator TagWithEvaluator, which first doesn't make sense as a word, and second doesn't reflect our internal convention. We usually name evaluators based on the state they act upon and evaluate, rather than the extension method names. We may have many extension methods that operate on the same state.

That said, we'll rename the TagWithEvaluator to QueryTagEvaluator. It won't affect the normal usage and won't be a breaking change for the majority of the users. But, for users who somehow directly reference and use this partial evaluator, it is a breaking change. It's a very recent feature, so I'd say let's make this change now, otherwise it will remain forever.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions