Updated null guard to optionally require nameof #149
Conversation
|
I don't think we want that global.json to be checked in, do we? I'm going to hold on this until we have an RTM release of .NET 6 that I'll install on the build agents. |
|
I honestly don't know about the I don't use a global file so I'm not really familiar with the use case, I think it pins the version of .NET used in the folder? 🤷 Ok holding until RTM makes sense, I'll try and remember to update the PR with the RTM bits soon after release as well. |
|
No worries. I'm sure I had a reason when I added it... Release coming very soon! Will be time for another major version update to this package I suspect. |
|
Yeah, I'll get this one updated quickly so we can move on the rest of them as close to release as possible 😃 |
|
@ardalis Do you need anything else from me on this one or are you just waiting for .net60 on build agents? |
|
ping @ardalis |
|
done! |
|
@ardalis Would you like me to submit the rest now you're happy with this one? |
|
Yes, but... there's a PR that is going to multiply the number of files dramatically. You should wait for it to be merged. |
|
Yeah I saw that, will wait for that and then get another submitted. (It's this right #159) |
|
Yes. It's merged now but I'm still working on cleaning up things and
getting other PRs dealt with.
…On Tue, Jan 18, 2022 at 12:06 PM Adam Stapleton ***@***.***> wrote:
Yeah I saw that, will wait for that and then get another submitted. (It's
this right #159 <#159>)
—
Reply to this email directly, view it on GitHub
<#149 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF66L3YDRTE2BFLIL4E43TUWWM2FANCNFSM5HCLQK2A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Steve Smith
http://ardalis.com | http://twitter.com/ardalis
|
|
Ok I'll wait a few days and then get started 😃 |
|
You're probably good now. I merged everything I could and release v4. |
|
Ok great I'll get on it sometime this week 👍 Thanks |
No description provided.