Adds Aspire #859
Merged
Adds Aspire #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardalis
approved these changes
Oct 28, 2024
|
What's left for this to be ready to merge? |
|
Hi @ardalis , The test that I added in the AspireHost test project is failing. Was investigating it, but I recently noticed that we have a comment about it in the ListContributorsQueryService.cs file that its expected with In memory databases. Unfortunately by default aspire uses in memory database to do integration testing. So was wondering if we need to have a real test in the aspire test project at all ? |
|
probably not. Alternately use a fake version of that service but that's probably not a good integration test... |
|
Alright , I will remove it and publish the PR or should I just leave it as a comment ? |
|
Go ahead and remove it. |
|
@ardalis this is now ready to be merged |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #846
Adds .NET Aspire specific parts to the template. Also introduces a boolen flag
--aspirethat allows template users to choose if they want Aspire included in the template during creation.The following projects were added to the template:
The template.json file was modified
New PackegeReferences were added to Directory.Packages.Props to conditionally add references based on the aspire flag.