-
-
Notifications
You must be signed in to change notification settings - Fork 3k
KISS principle & fluent builder pattern #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sample/src/NimblePros.SampleToDo.Core/ContributorAggregate/Contributor.cs
Show resolved
Hide resolved
sample/src/NimblePros.SampleToDo.Core/ContributorAggregate/Contributor.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just curious as I try to understand the changes being proposed here. How does the KISS principle apply to having SetSomeProperty methods (potentially many methods if you're doing them individually)? Doesn't introducing setter methods make the Constructor, which itself is a setter, more complex?
Hello Kyle, |
I'm going to pull these in for now. My goal regarding checking Name in multiple places is to fix that using a Value Object rather than using a primitive, and then the check will live in the Value Object (only). But this will work for now and overall the other changes are helpful. |
If it's good practice, may I do the same for the rest of the project's setters?