Skip to content

Update Contributor PhoneNumber nullability for consistency #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 29, 2024
Merged

Update Contributor PhoneNumber nullability for consistency #686

merged 3 commits into from
Feb 29, 2024

Conversation

KyleMcMaster
Copy link
Collaborator

@KyleMcMaster KyleMcMaster commented Feb 29, 2024 •
edited
Loading

  • Since the domain model for Contributor has a nullable PhoneNumber, ContributorDTO should also have that nullability rather than conflicting between null and "".
  • Minor code cleanup as well

Related to #682

@ardalis ardalis merged commit dfc4b02 into main Feb 29, 2024
@ardalis ardalis deleted the kylemcmaster/fix-contributor-dto-nullability branch February 29, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardalis ardalis ardalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleMcMaster @ardalis