Skip to content

Conversation

leoluz
Copy link
Contributor

@leoluz leoluz commented Nov 2, 2021

Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com

Fixes argoproj/argo-cd#5584

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #345 (952a406) into master (27374da) will increase coverage by 0.07%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   49.40%   49.48%   +0.07%     
==========================================
  Files          41       41              
  Lines        3297     3302       +5     
==========================================
+ Hits         1629     1634       +5     
  Misses       1509     1509              
  Partials      159      159              
Impacted Files Coverage Δ
pkg/diff/diff.go 63.20% <57.14%> (+0.41%) ⬆️
pkg/health/health_hpa.go 83.11% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27374da...952a406. Read the comment docs.

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit c0b63af into argoproj:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using an explicitly empty secret throws error
2 participants