chore: wrap errors #732
Merged
chore: wrap errors #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
1477b99 to
cba79dc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #732 +/- ##
==========================================
- Coverage 54.26% 53.62% -0.65%
==========================================
Files 64 64
Lines 6164 6514 +350
==========================================
+ Hits 3345 3493 +148
- Misses 2549 2745 +196
- Partials 270 276 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
agaudreault
reviewed
Jun 6, 2025
|
agaudreault
approved these changes
Jun 6, 2025
RoelofKuijpers
pushed a commit
to RoelofKuijpers/gitops-engine
that referenced
this pull request
Jul 29, 2025
* chore: wrap errors Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * report list result along with error Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fixes Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Roelof Kuijpers <roelof.kuijpers@energyessentials.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things are hard to debug unless error messages are wrapped. Long live verbosity.
Argo CD test PR: argoproj/argo-cd#23282