feat: Enable SkipDryRunOnMissingResource sync option on Application level #712
Conversation
Signed-off-by: pasha <pasha.k@fyxt.com>
…evel Signed-off-by: pasha <pasha.k@fyxt.com>
…to feat/skip-dry-run-on-app-level
…ontext - Introduced a new option to skip dry run verification for missing resources at the application level. - Updated the sync context to include a flag for this feature. - Enhanced tests to cover scenarios where the skip dry run annotation is applied to all resources.
…-dry-run-on-app-level
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #712 +/- ##
==========================================
- Coverage 54.26% 53.64% -0.63%
==========================================
Files 64 64
Lines 6164 6474 +310
==========================================
+ Hits 3345 3473 +128
- Misses 2549 2725 +176
- Partials 270 276 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
couldn't you just use the new skipDryrun functionality? that one is on application scope? (not yet available in argoCD, but implemented in the git-ops engine) |
|
Will not it skip dry run completely and not just in case when resource is missing? the whole idea is not to configure SkipDryRunOnMissingResource for every resource and has it on application level. So it will ignore resource not found , but still will do dry run and probably catch other errors |
…evel (argoproj#712) * fix: go mod tidy is not working due to k8s.io/externaljwt dependency Signed-off-by: pasha <pasha.k@fyxt.com> * feat: Enable SkipDryRunOnMissingResource sync option on Application level Signed-off-by: pasha <pasha.k@fyxt.com> * feat: Enable SkipDryRunOnMissingResource sync option on Application level * feat: add support for skipping dry run on missing resources in sync context - Introduced a new option to skip dry run verification for missing resources at the application level. - Updated the sync context to include a flag for this feature. - Enhanced tests to cover scenarios where the skip dry run annotation is applied to all resources. --------- Signed-off-by: pasha <pasha.k@fyxt.com> Co-authored-by: pasha <pasha.k@fyxt.com> Signed-off-by: Roelof Kuijpers <roelof.kuijpers@energyessentials.nl>
Related to argoproj/argo-cd#21790