feat: return images from resources when sync occurs #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
922aecd to
3f1734a
Compare
andrii-korotkov-verkada
approved these changes
Nov 27, 2024
5281e57 to
ae4000b
Compare
andrea-mosk
reviewed
Nov 27, 2024
pkg/utils/kube/kube.go
Outdated
| for _, container := range containers { | ||
| containerMap, ok := container.(map[string]interface{}) | ||
| if !ok { | ||
| return nil |
There was a problem hiding this comment.
Should we continue instead of returning here? It might be something related to the single container only
There was a problem hiding this comment.
Makes sense to extract as much data as possible. Added continue on 5b2c46f but maybe @andrii-korotkov-verkada has a different take
| @@ -404,6 +404,34 @@ func GetDeploymentReplicas(u *unstructured.Unstructured) *int64 { | |||
| return &val | |||
| } | |||
|
|
|||
| func GetResourceImages(u *unstructured.Unstructured) []string { | |||
There was a problem hiding this comment.
For CronJobs it seems that the image is under spec.jobTemplate.spec.template.spec.containers. Should we also check there?
andrea-mosk
approved these changes
Nov 27, 2024
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #642 +/- ##
==========================================
- Coverage 54.26% 53.55% -0.72%
==========================================
Files 64 64
Lines 6164 6442 +278
==========================================
+ Hits 3345 3450 +105
- Misses 2549 2715 +166
- Partials 270 277 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
50c907f to
a989b44
Compare
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
…for cronjobs Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
a989b44 to
e6f8fbe
Compare
|
Can you create a PR to Argo CD updating the EDIT: Nvm, found it argoproj/argo-cd#20954. Do the e2e pass? |
gdsoumya
approved these changes
Feb 20, 2025
|
@rumstead done in argoproj/argo-cd#20954, tests are now passing |
14 tasks
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
f14771b to
914b89c
Compare
|
Added new benchmark test for the sync operation. These are the results: command: 3 images5 images10 imagesOverall, we see a small increase in time/operation for a small amount of images (11% for 3 images), and it gets larger as the images grow (36% for 10 images). This is expected, since we are now iterating over images. Even with this growth, the total value is still quite low. |
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
b985995 to
4fbe25e
Compare
|
crenshaw-dev
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the Gitops side of this issue: argoproj/argo-cd#20896
Adds an api to
kube.goto get the images from a resource. Adds those images toResourceSyncResult. This API accounts for how different k8s resources define the images.