Skip to content

Conversation

philippemerle
Copy link

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Before this PR, all custom resource definitions have no release and chart metadata labels as illustrated in following diagrams generated with KubeDiagrams:

argo-cd original

argo-events original

Let's note that in the previous diagram the Argo Events controller manager config map is not labelled to be part of the controller manager component.

argo-rollouts original

argo-workflows original

This PR adds missed metadata labels as illustrated in following diagrams generated with KubeDiagrams:

argo-cd corrected

argo-events corrected

argo-rollouts corrected

argo-workflows corrected

@philippemerle philippemerle changed the title Add missed metadata labels chore: Add missed metadata labels Jun 9, 2025
@philippemerle philippemerle changed the title chore: Add missed metadata labels chore(argo-cd, argo-events, argo-rollouts, argo-workflows): Add missed metadata labels Jun 9, 2025
Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
…ig map

Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
@jmeridth
Copy link
Member

Please split this PR into a PR per chart and update the Chart.yaml per PR as is required (version and change info). Thank you

@philippemerle
Copy link
Author

I will do it asap in coming days.

@mkilchhofer mkilchhofer marked this pull request as draft July 8, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants