Skip to content

chore: cherry pick #24235 to release-3.0 #24237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2025
Merged

chore: cherry pick #24235 to release-3.0 #24237

merged 3 commits into from
Aug 22, 2025

Conversation

FourFifthsCode
Copy link
Contributor

@FourFifthsCode FourFifthsCode commented Aug 22, 2025 •
edited
Loading

mtbennett-godaddy and others added 2 commits August 22, 2025 14:03
@mtbennett-godaddy @FourFifthsCode
avoid unnecessary GetSettings calls
60c537b 
Signed-off-by: Matthew Bennett <mtbennett@godaddy.com>

Signed-off-by: Codey Jenkins <FourFifthsCode@users.noreply.github.com>
@FourFifthsCode
fix: keep only GetCluster changes and revert ListClusters/GetClusterS…
a4bfe39 
…erversByName changes

Signed-off-by: Codey Jenkins <FourFifthsCode@users.noreply.github.com>
@FourFifthsCode FourFifthsCode requested a review from a team as a code owner August 22, 2025 18:07
@codecov Codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.93%. Comparing base (d6a04a3) to head (a4bfe39).
⚠️ Report is 75 commits behind head on release-3.0.

Files with missing lines Patch % Lines
util/db/cluster.go 62.50% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-3.0   #24237      +/-   ##
===============================================
+ Coverage        55.90%   55.93%   +0.02%     
===============================================
  Files              343      344       +1     
  Lines            57338    57466     +128     
===============================================
+ Hits             32056    32141      +85     
- Misses           22633    22665      +32     
- Partials          2649     2660      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agaudreault
Copy link
Member

LGTM. Failing unit test seems unrelated.

@agaudreault agaudreault enabled auto-merge (squash) August 22, 2025 20:25
@agaudreault agaudreault merged commit d6e0e5c into argoproj:release-3.0 Aug 22, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FourFifthsCode @agaudreault @crenshaw-dev @mtbennett-godaddy