Skip to content

fix: High Application Controller CPU Usage - Reduce calls to db.GetSettings #24235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2025
Merged

fix: High Application Controller CPU Usage - Reduce calls to db.GetSettings #24235

merged 2 commits into from
Aug 22, 2025

Conversation

FourFifthsCode
Copy link
Contributor

@FourFifthsCode FourFifthsCode commented Aug 22, 2025 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Fixes #24167
Cherry picked changes from #24021

These changes are enough to reduce the high cpu memory.
Thanks @mtbennett-godaddy for the great work!

Ongoing work to improve GetSettings performance #24080

mtbennett-godaddy and others added 2 commits August 1, 2025 23:13
@mtbennett-godaddy
avoid unnecessary GetSettings calls
3af0c19 
Signed-off-by: Matthew Bennett <mtbennett@godaddy.com>
@FourFifthsCode
fix: keep only GetCluster changes and revert ListClusters/GetClusterS…
94c94c5 
…erversByName changes

Signed-off-by: Codey Jenkins <FourFifthsCode@users.noreply.github.com>
@FourFifthsCode FourFifthsCode requested a review from a team as a code owner August 22, 2025 16:21
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Aug 22, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@FourFifthsCode FourFifthsCode changed the title High Application Controller/CPU Usage - Reduce calls to db.GetSettings fix: High Application Controller/CPU Usage - Reduce calls to db.GetSettings Aug 22, 2025
@FourFifthsCode FourFifthsCode changed the title fix: High Application Controller/CPU Usage - Reduce calls to db.GetSettings fix: High Application Controller CPU/Memory Usage - Reduce calls to db.GetSettings Aug 22, 2025
@FourFifthsCode FourFifthsCode changed the title fix: High Application Controller CPU/Memory Usage - Reduce calls to db.GetSettings fix: High Application Controller CPU Usage - Reduce calls to db.GetSettings Aug 22, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@323f993). Learn more about missing BASE report.
⚠️ Report is 74 commits behind head on master.

Files with missing lines Patch % Lines
util/db/cluster.go 62.50% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #24235   +/-   ##
=========================================
  Coverage          ?   60.13%           
=========================================
  Files             ?      347           
  Lines             ?    59890           
  Branches          ?        0           
=========================================
  Hits              ?    36014           
  Misses            ?    20988           
  Partials          ?     2888

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crenshaw-dev
crenshaw-dev approved these changes Aug 22, 2025
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code's trivial, and we can save improvements for GetSettings for another PR. lgtm!

@crenshaw-dev crenshaw-dev merged commit 7129a2c into argoproj:master Aug 22, 2025
34 of 35 checks passed
@crenshaw-dev
Copy link
Member

/cherry-pick release-3.1

@crenshaw-dev
Copy link
Member

/cherry-pick release-3.0

This was referenced Aug 22, 2025
Merged
Merged
agaudreault pushed a commit that referenced this pull request Aug 22, 2025
@FourFifthsCode @mtbennett-godaddy
chore: cherry pick #24235 to release-3.1 (#24238)
70dde2c 
Signed-off-by: Codey Jenkins <FourFifthsCode@users.noreply.github.com>
Co-authored-by: Matthew Bennett <mtbennett@godaddy.com>
agaudreault added a commit that referenced this pull request Aug 22, 2025
@FourFifthsCode @mtbennett-godaddy @agaudreault
chore: cherry pick #24235 to release-3.0 (#24237)
d6e0e5c 
Signed-off-by: Codey Jenkins <FourFifthsCode@users.noreply.github.com>
Co-authored-by: Matthew Bennett <mtbennett@godaddy.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
gpamit pushed a commit to gpamit/argo-cd that referenced this pull request Aug 23, 2025
@FourFifthsCode @mtbennett-godaddy @gpamit
fix: High Application Controller CPU Usage - Reduce calls to db.GetSe…
a66ff66 
…ttings (argoproj#24235)

Signed-off-by: Codey Jenkins <FourFifthsCode@users.noreply.github.com>
Co-authored-by: Matthew Bennett <mtbennett@godaddy.com>
Signed-off-by: Amit Gupta <amit.gupta@wpengine.com>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@FourFifthsCode @mtbennett-godaddy @enneitex
fix: High Application Controller CPU Usage - Reduce calls to db.GetSe…
dc7aee3 
…ttings (argoproj#24235)

Signed-off-by: Codey Jenkins <FourFifthsCode@users.noreply.github.com>
Co-authored-by: Matthew Bennett <mtbennett@godaddy.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
downfa11 pushed a commit to downfa11/argo-cd that referenced this pull request Aug 25, 2025
@FourFifthsCode @mtbennett-godaddy @downfa11
fix: High Application Controller CPU Usage - Reduce calls to db.GetSe…
ca6c0bb 
…ttings (argoproj#24235)

Signed-off-by: Codey Jenkins <FourFifthsCode@users.noreply.github.com>
Co-authored-by: Matthew Bennett <mtbennett@godaddy.com>
This was referenced Sep 2, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

High Application Controller CPU/Memory Usage in version 3.0.11
3 participants
@FourFifthsCode @crenshaw-dev @mtbennett-godaddy