Skip to content

fix(util): Fix default key exchange algorthims used for SSH connection to be FIPS compliant (#24086) (cherry-pick 3.1) #24166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

fix(util): Fix default key exchange algorthims used for SSH connection to be FIPS compliant (#24086) (cherry-pick 3.1) #24166

merged 1 commit into from
Aug 15, 2025

Conversation

anandf
Copy link
Member

@anandf anandf commented Aug 15, 2025

Cherry pick of PR #24086
Fixes #24155

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@anandf
fix(util): Fix default key exchange algorthims used for SSH connectio…
3e0b953 
…n to be FIPS compliant (argoproj#24086)

Signed-off-by: anandf <anjoseph@redhat.com>
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Aug 15, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@anandf anandf changed the base branch from master to release-3.1 August 15, 2025 08:32
@anandf anandf marked this pull request as ready for review August 15, 2025 08:33
@anandf anandf requested a review from a team as a code owner August 15, 2025 08:33
@blakepettersson blakepettersson merged commit fdd0991 into argoproj:release-3.1 Aug 15, 2025
20 of 22 checks passed
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.21%. Comparing base (a0f0653) to head (3e0b953).
⚠️ Report is 1 commits behind head on release-3.1.

Files with missing lines Patch % Lines
util/git/ssh.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-3.1   #24166      +/-   ##
===============================================
- Coverage        60.26%   60.21%   -0.05%     
===============================================
  Files              345      345              
  Lines            59184    59189       +5     
===============================================
- Hits             35665    35641      -24     
- Misses           20644    20661      +17     
- Partials          2875     2887      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakepettersson blakepettersson blakepettersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

repo server panics when using SSH based repo URL in FIPS mode enabled cluster
2 participants
@anandf @blakepettersson