Skip to content

Conversation

reggie-k
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Copy link

bunnyshell bot commented Jul 24, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

reggie-k added 2 commits July 27, 2025 11:21
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k reggie-k marked this pull request as ready for review July 27, 2025 09:11
@reggie-k reggie-k requested review from a team as code owners July 27, 2025 09:11
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only small comment

For users with label-based tracking and Applications that have `ApplyOutOfSyncOnly=true` syncOptions, an explicit sync has to be run for those Applications after you upgrade.
Here is an example command, that syncs such an Application, it can be run after you [obtain a token](../../developer-guide/api-docs.md#authorization) to Argo CD API:
```sh
curl -X POST -H "Authorization: Bearer $ARGOCD_TOKEN" -H "Content-Type: application/json" -d '{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better to provide example with CLI and not API? i think cli is more popular case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, impossible to mitigate with CLI, there is the PR in progress to fix the CLI: #23910
While the PR is a WIP, we should give users at least some remediation option if they have many apps and can't sync them all manually with UI.

@pasha-codefresh pasha-codefresh merged commit 90eae48 into argoproj:master Jul 27, 2025
24 checks passed
@reggie-k
Copy link
Member Author

reggie-k commented Jul 27, 2025

/cherry-pick release-3.1

@reggie-k
Copy link
Member Author

/cherry-pick release-3.0

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 27, 2025
…hat use ApplyOutOfSyncOnly=true (#23918)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 27, 2025
…hat use ApplyOutOfSyncOnly=true (#23918)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k
Copy link
Member Author

/cherry-pick release-3.1

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 27, 2025
…hat use ApplyOutOfSyncOnly=true (#23918)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
reggie-k added a commit that referenced this pull request Jul 30, 2025
…hat use ApplyOutOfSyncOnly=true (cherry-pick #23918) (#23959)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Co-authored-by: Regina Voloshin <regina.voloshin@codefresh.io>
ishitasequeira pushed a commit that referenced this pull request Aug 4, 2025
…hat use ApplyOutOfSyncOnly=true (cherry-pick #23918) (#23957)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Co-authored-by: Regina Voloshin <regina.voloshin@codefresh.io>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
…hat use ApplyOutOfSyncOnly=true (argoproj#23918)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: enneitex <etienne.divet@gmail.com>
downfa11 pushed a commit to downfa11/argo-cd that referenced this pull request Aug 25, 2025
…hat use ApplyOutOfSyncOnly=true (argoproj#23918)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants