feat(health): CronJob health and suspend, resume and terminate Job actions #23991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23991 +/- ##
==========================================
+ Coverage 60.21% 60.31% +0.09%
==========================================
Files 346 347 +1
Lines 59275 59312 +37
==========================================
+ Hits 35693 35772 +79
+ Misses 20729 20686 -43
- Partials 2853 2854 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
This was referenced Aug 13, 2025
13 tasks
enneitex
pushed a commit
to enneitex/argo-cd
that referenced
this pull request
Aug 24, 2025
…tions (argoproj#23991) Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: enneitex <etienne.divet@gmail.com>
downfa11
pushed a commit
to downfa11/argo-cd
that referenced
this pull request
Aug 25, 2025
…tions (argoproj#23991) Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
People using CronJob may see their application go to Progressing more often based on CronJobs schedule. If a CronJob is always running a job, then the annotation
argocd.argoproj.io/ignore-healthcheck: 'true'can be used for the CronJob health to not affect the overall Application.An improvement could be to have
argocd.argoproj.io/ignore-healthcheck: 'progressing'if we want the application to reflect the health of a CronJob, but not go to Progressing state whenever a Job is running. (#19126)Currently, the behavior is consistent with Deployment/Rollout changing to progressing when being scaled up and down by an HPA after the deployment
Screen.Recording.low.qal.mov
Fixes #11571