Skip to content

fix(appset): When Appset is deleted, the controller should reconcile applicationset #23723 (cherry-pick ##23823) #23834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

fix(appset): When Appset is deleted, the controller should reconcile applicationset #23723 (cherry-pick ##23823) #23834

merged 1 commit into from
Jul 17, 2025

Conversation

rumstead
Copy link
Member

…applicationset #23723

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@sangdammad @rumstead
fix(appset): When Appset is deleted, the controller should reconcile …
91ea761 
…applicationset argoproj#23723

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead rumstead requested a review from a team as a code owner July 17, 2025 14:03
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.97%. Comparing base (3ab0e9c) to head (91ea761).
Report is 8 commits behind head on release-3.0.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-3.0   #23834      +/-   ##
===============================================
+ Coverage        55.91%   55.97%   +0.05%     
===============================================
  Files              343      344       +1     
  Lines            57448    57449       +1     
===============================================
+ Hits             32122    32157      +35     
+ Misses           22671    22642      -29     
+ Partials          2655     2650       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rumstead rumstead merged commit fc27c4d into argoproj:release-3.0 Jul 17, 2025
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

+1 more reviewer

@wanghong230 wanghong230 wanghong230 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rumstead @crenshaw-dev @wanghong230 @sangdammad