Skip to content

feat(kustomize): multiple base support via multi-source references (#23872) #23873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(kustomize): multiple base support via multi-source references (#23872) #23873

wants to merge 1 commit into from
+424 −8

Conversation

cardoe
Copy link
Contributor

@cardoe cardoe commented Jul 21, 2025 •
edited
Loading

Following #21674 which allowed ignoring components and #23486 which allowed having components specified in a monorepo, this allows specifying components by reference the same way that helm values files can be specified. This is useful for people that store components in branches or are doing testing by using branches against the main application components. Fixes #23872.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@cardoe cardoe requested review from a team as code owners July 21, 2025 20:08
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jul 21, 2025 •
edited
Loading

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

cardoe added a commit to cardoe/argo-cd that referenced this pull request Jul 21, 2025
@cardoe
feat(kustomize): add support for components by reference (argoproj#23872
2f3f911 
)

This is an implmentation of argoproj#23873. Following argoproj#21674 which allowed
ignoring components and argoproj#23486 which allowed having components
specified in a monorepo, this allows specifying components by reference
the same way that helm values files can be specified. Today kustomize
supports having URL references to components but ArgoCD has no concept
of this and does not detect that the component might have changed.
Using the reference form ArgoCD is aware of the changes to components
and can re-run any sync that is configured. This is useful for people
that store components in branches or are doing testing by using
branches against the main application components. Fixes argoproj#23872

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
@cardoe cardoe force-pushed the kustomize-component-refs branch from 1f20259 to 2f3f911 Compare July 21, 2025 21:06
cardoe added a commit to cardoe/argo-cd that referenced this pull request Jul 21, 2025
@cardoe
feat(kustomize): add support for components by reference (argoproj#23872
2695c70 
)

This is an implmentation of argoproj#23873. Following argoproj#21674 which allowed
ignoring components and argoproj#23486 which allowed having components
specified in a monorepo, this allows specifying components by reference
the same way that helm values files can be specified. Today kustomize
supports having URL references to components but ArgoCD has no concept
of this and does not detect that the component might have changed.
Using the reference form ArgoCD is aware of the changes to components
and can re-run any sync that is configured. This is useful for people
that store components in branches or are doing testing by using
branches against the main application components. Fixes argoproj#23872

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
@cardoe cardoe force-pushed the kustomize-component-refs branch from 2f3f911 to 2695c70 Compare July 21, 2025 21:35
@codecov Codecov
Copy link

codecov bot commented Jul 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.51724% with 20 lines in your changes missing coverage. Please review.

Project coverage is 60.27%. Comparing base (d5383de) to head (5f1805a).

Files with missing lines Patch % Lines
util/kustomize/kustomize.go 48.48% 14 Missing and 3 partials ⚠️
reposerver/repository/repository.go 88.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #23873      +/-   ##
==========================================
+ Coverage   60.18%   60.27%   +0.08%     
==========================================
  Files         346      346              
  Lines       59248    59298      +50     
==========================================
+ Hits        35656    35739      +83     
+ Misses      20730    20707      -23     
+ Partials     2862     2852      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cardoe
feat(kustomize): add support for components by reference (argoproj#23872
5f1805a 
)

This is an implmentation of argoproj#23873. Following argoproj#21674 which allowed
ignoring components and argoproj#23486 which allowed having components
specified in a monorepo, this allows specifying components by reference
the same way that helm values files can be specified. Today kustomize
supports having URL references to components but ArgoCD has no concept
of this and does not detect that the component might have changed.
Using the reference form ArgoCD is aware of the changes to components
and can re-run any sync that is configured. This is useful for people
that store components in branches or are doing testing by using
branches against the main application components. Fixes argoproj#23872

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
@cardoe cardoe force-pushed the kustomize-component-refs branch from 2695c70 to 5f1805a Compare July 22, 2025 12:58
cardoe added a commit to rackerlabs/understack that referenced this pull request Jul 22, 2025
@cardoe
feat(deploy): enable components for app deploy
e84cb40 
The intention of the deploy repo is to provide overrides of the
defaults. The proper way to do this via kustomize is to use components
which ArgoCD gives use a better way to use like Helm values files. This
enables our deploy repo to use these components and documents how this
should appear in the deploy repo.

This depends on argoproj/argo-cd#23873
@cardoe cardoe changed the title feat(kustomize): add support for components by reference (#23872) feat(kustomize): multiple base support via multi-source references (#23872) Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kustomize: multiple base support via references with multiple sources
1 participant
@cardoe