Skip to content

fix: helm GetTags cache writing #23865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2025
Merged

fix: helm GetTags cache writing #23865

merged 1 commit into from
Jul 26, 2025

Conversation

mclarke47
Copy link
Contributor

@mclarke47 mclarke47 commented Jul 21, 2025 •
edited
Loading

If you use version wilcards and an OCI helm chart the repo server will lookup the tag cache, but it will never write the values.

Fixes #21075

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@linghaoSu @mclarke47
fix: helm GetTags cache writing
22c9737 
Signed-off-by: Matthew Clarke <mclarke@spotify.com>
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jul 21, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@mclarke47 mclarke47 force-pushed the helm-tag-nil-cache-fix2 branch from a0674e3 to 22c9737 Compare July 21, 2025 14:17
@codecov Codecov
Copy link

codecov bot commented Jul 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@3e6f11e). Learn more about missing BASE report.
⚠️ Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
util/helm/client.go 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #23865   +/-   ##
=========================================
  Coverage          ?   60.14%           
=========================================
  Files             ?      346           
  Lines             ?    59252           
  Branches          ?        0           
=========================================
  Hits              ?    35635           
  Misses            ?    20746           
  Partials          ?     2871

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mclarke47 mclarke47 marked this pull request as ready for review July 21, 2025 15:53
@mclarke47 mclarke47 requested a review from a team as a code owner July 21, 2025 15:53
blakepettersson
blakepettersson approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mclarke47
Copy link
Contributor Author

@blakepettersson thanks! could you merge?

nitishfy
nitishfy approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blakepettersson blakepettersson merged commit 9895f55 into argoproj:master Jul 26, 2025
31 checks passed
@blakepettersson
Copy link
Member

/cherry-pick release-3.1

@blakepettersson
Copy link
Member

/cherry-pick release-3.0

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 26, 2025
@mclarke47 @linghaoSu
fix: helm GetTags cache writing (#23865)
6dfa160 
Signed-off-by: Matthew Clarke <mclarke@spotify.com>
Co-authored-by: Linghao Su <linghao.su@daocloud.io>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jul 26, 2025
Merged
@blakepettersson
Copy link
Member

/cherry-pick release-2.14

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 26, 2025
@mclarke47 @linghaoSu
fix: helm GetTags cache writing (#23865)
19ba27c 
Signed-off-by: Matthew Clarke <mclarke@spotify.com>
Co-authored-by: Linghao Su <linghao.su@daocloud.io>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jul 26, 2025
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 26, 2025
@mclarke47 @linghaoSu
fix: helm GetTags cache writing (#23865)
041122c 
Signed-off-by: Matthew Clarke <mclarke@spotify.com>
Co-authored-by: Linghao Su <linghao.su@daocloud.io>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jul 26, 2025
Closed
blakepettersson pushed a commit that referenced this pull request Jul 28, 2025
@gcp-cherry-pick-bot @mclarke47 @linghaoSu
fix: helm GetTags cache writing (cherry-pick #23865) (#23953)
d11bf1a 
Signed-off-by: Matthew Clarke <mclarke@spotify.com>
Co-authored-by: Matthew Clarke <matthewclarke47@gmail.com>
Co-authored-by: Linghao Su <linghao.su@daocloud.io>
blakepettersson pushed a commit that referenced this pull request Jul 28, 2025
@gcp-cherry-pick-bot @mclarke47 @linghaoSu
fix: helm GetTags cache writing (cherry-pick #23865) (#23952)
26c63b9 
Signed-off-by: Matthew Clarke <mclarke@spotify.com>
Co-authored-by: Matthew Clarke <matthewclarke47@gmail.com>
Co-authored-by: Linghao Su <linghao.su@daocloud.io>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@mclarke47 @linghaoSu @enneitex
fix: helm GetTags cache writing (argoproj#23865)
de97d7f 
Signed-off-by: Matthew Clarke <mclarke@spotify.com>
Co-authored-by: Linghao Su <linghao.su@daocloud.io>
Signed-off-by: enneitex <etienne.divet@gmail.com>
downfa11 pushed a commit to downfa11/argo-cd that referenced this pull request Aug 25, 2025
@mclarke47 @linghaoSu @downfa11
fix: helm GetTags cache writing (argoproj#23865)
ddfa2f5 
Signed-off-by: Matthew Clarke <mclarke@spotify.com>
Co-authored-by: Linghao Su <linghao.su@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakepettersson blakepettersson blakepettersson approved these changes

@nitishfy nitishfy nitishfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to store tags list cache for repo: helm index data is nil, skipping cache
4 participants
@mclarke47 @blakepettersson @nitishfy @linghaoSu