Skip to content

Conversation

jaqxues
Copy link
Contributor

@jaqxues jaqxues commented Jun 29, 2025

Fixes #23571

Fix "not found" toast in applications generated by applicationset in non-default namespace. Caused by incorrect query. The query does not follow the swagger specification itself for argocd. Hence, the UI only works for ApplicationSets in the normal default namespace, not with applicationsets in any namespace. This should fix the toasts "applicationset .... not found".

The fix was tested locally on a kind cluster, no e2e tests seem to be affected.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
@jaqxues jaqxues requested a review from a team as a code owner June 29, 2025 16:45
Copy link

bunnyshell bot commented Jun 29, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@ishitasequeira ishitasequeira merged commit 8d47727 into argoproj:master Jun 30, 2025
25 checks passed
@blakepettersson
Copy link
Member

/cherry-pick release-3.1

@blakepettersson
Copy link
Member

/cherry-pick release-3.0

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 30, 2025
Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
@blakepettersson
Copy link
Member

/cherry-pick release-2.14

Copy link

Cherry-pick failed with Merge error 8d47727d38a17c510efea3234cb3597c2a285b7f into temp-cherry-pick-0b7c81-release-3.0

Copy link

Cherry-pick failed with Merge error 8d47727d38a17c510efea3234cb3597c2a285b7f into temp-cherry-pick-0b7c81-release-2.14

blakepettersson pushed a commit that referenced this pull request Jun 30, 2025
… (#23604)

Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
Co-authored-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
cjcocokrisp pushed a commit to cjcocokrisp/argo-cd that referenced this pull request Jun 30, 2025
Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
cjcocokrisp pushed a commit to cjcocokrisp/argo-cd that referenced this pull request Jun 30, 2025
Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
cjcocokrisp pushed a commit to cjcocokrisp/argo-cd that referenced this pull request Jun 30, 2025
Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
cjcocokrisp pushed a commit to cjcocokrisp/argo-cd that referenced this pull request Jun 30, 2025
Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApplicationSet not found Toast
4 participants