-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix: UI error with ApplicationSet in any namespace #23601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ishitasequeira
merged 1 commit into
argoproj:master
from
jaqxues:fix-23571-ui-applicationset-404
Jun 30, 2025
Merged
fix: UI error with ApplicationSet in any namespace #23601
ishitasequeira
merged 1 commit into
argoproj:master
from
jaqxues:fix-23571-ui-applicationset-404
Jun 30, 2025
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
rumstead
approved these changes
Jun 29, 2025
ishitasequeira
approved these changes
Jun 30, 2025
/cherry-pick release-3.1 |
/cherry-pick release-3.0 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jun 30, 2025
Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
/cherry-pick release-2.14 |
Cherry-pick failed with |
Cherry-pick failed with |
blakepettersson
pushed a commit
that referenced
this pull request
Jun 30, 2025
… (#23604) Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com> Co-authored-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
cjcocokrisp
pushed a commit
to cjcocokrisp/argo-cd
that referenced
this pull request
Jun 30, 2025
Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
cjcocokrisp
pushed a commit
to cjcocokrisp/argo-cd
that referenced
this pull request
Jun 30, 2025
Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
cjcocokrisp
pushed a commit
to cjcocokrisp/argo-cd
that referenced
this pull request
Jun 30, 2025
Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
cjcocokrisp
pushed a commit
to cjcocokrisp/argo-cd
that referenced
this pull request
Jun 30, 2025
Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com>
enneitex
pushed a commit
to enneitex/argo-cd
that referenced
this pull request
Aug 24, 2025
Signed-off-by: jaqxues <32979131+jaqxues@users.noreply.github.com> Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23571
Fix "not found" toast in applications generated by applicationset in non-default namespace. Caused by incorrect query. The query does not follow the swagger specification itself for argocd. Hence, the UI only works for ApplicationSets in the normal default namespace, not with applicationsets in any namespace. This should fix the toasts "applicationset .... not found".
The fix was tested locally on a kind cluster, no e2e tests seem to be affected.
Checklist: