Skip to content

Conversation

crenshaw-dev
Copy link
Member

#20097 introduced breaking API changes.

This PR reverts those changes in favor of a V2 endpoint to provide the new features.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner July 8, 2025 16:21
Copy link

bunnyshell bot commented Jul 8, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@crenshaw-dev crenshaw-dev marked this pull request as draft July 8, 2025 16:21
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev marked this pull request as ready for review July 8, 2025 19:13
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner July 8, 2025 19:13
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 2.63158% with 37 lines in your changes missing coverage. Please review.

Project coverage is 60.23%. Comparing base (e692a22) to head (56c362f).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/app_actions.go 0.00% 19 Missing ⚠️
server/application/application.go 5.26% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #23695      +/-   ##
==========================================
+ Coverage   60.19%   60.23%   +0.04%     
==========================================
  Files         346      346              
  Lines       59202    59238      +36     
==========================================
+ Hits        35636    35683      +47     
- Misses      20696    20698       +2     
+ Partials     2870     2857      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing it so quickly.

Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crenshaw-dev crenshaw-dev merged commit f420cce into argoproj:master Jul 9, 2025
28 checks passed
@crenshaw-dev
Copy link
Member Author

/cherry-pick release-3.1

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 9, 2025
…#23695)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Jul 9, 2025
… (cherry-pick #23695) (#23709)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jul 9, 2025
…argoproj#23695)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ManishTechie pushed a commit to ManishTechie/argo-cd that referenced this pull request Jul 9, 2025
…argoproj#23695)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Manish Kumar <mnskumar07@gmail.com>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
…argoproj#23695)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants