fix(health): CRD health check message (#23690) #23691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23691 +/- ##
==========================================
+ Coverage 60.19% 60.23% +0.04%
==========================================
Files 346 346
Lines 59202 59202
==========================================
+ Hits 35636 35660 +24
+ Misses 20696 20685 -11
+ Partials 2870 2857 -13 ☔ View full report in Codecov by Sentry. |
andrii-korotkov
approved these changes
Jul 10, 2025
rumstead
approved these changes
Jul 10, 2025
|
/cherry-pick release-3.1 |
|
/cherry-pick release-3.0 |
crenshaw-dev
added a commit
that referenced
this pull request
Jul 10, 2025
…23738) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jul 10, 2025
…23739) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
enneitex
pushed a commit
to enneitex/argo-cd
that referenced
this pull request
Aug 24, 2025
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The health check message currently is the message of "whatever condition was observed last," even if the condition health is based on some other condition.
I've changed the health check to quit early if it observes a condition which would make the resource Degraded or Progressing. As a result, it always returns the message most relevant to that condition.
I've updated the test to change the condition order in a way that triggers the bug.