fix: improves the ui message when an operation is terminated due to controller sync timeout #23657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
…ller sync timeout with pending retries Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
790333c to
89ed50c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23657 +/- ##
==========================================
- Coverage 60.29% 60.25% -0.04%
==========================================
Files 346 346
Lines 59192 59192
==========================================
- Hits 35691 35668 -23
- Misses 20631 20654 +23
Partials 2870 2870 ☔ View full report in Codecov by Sentry. |
nitishfy
approved these changes
Jul 4, 2025
agaudreault
approved these changes
Jul 4, 2025
|
/cherry-pick release-3.0 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 7, 2025
…ontroller sync timeout (#23657) Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
|
/cherry-pick release-3.1 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 7, 2025
…ontroller sync timeout (#23657) Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
|
/cherry-pick release-2.14 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 7, 2025
…ontroller sync timeout (#23657) Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jul 9, 2025
…ontroller sync timeout (argoproj#23657) Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ManishTechie
pushed a commit
to ManishTechie/argo-cd
that referenced
this pull request
Jul 9, 2025
…ontroller sync timeout (argoproj#23657) Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com> Signed-off-by: Manish Kumar <mnskumar07@gmail.com>
agaudreault
reviewed
Aug 2, 2025
| @@ -1471,7 +1471,7 @@ func (ctrl *ApplicationController) processRequestedAppOperation(app *appv1.Appli | |||
| } else { | |||
| state.Phase = synccommon.OperationRunning | |||
| state.RetryCount++ | |||
| state.Message = fmt.Sprintf("%s. Retrying attempt #%d at %s.", state.Message, state.RetryCount, retryAt.Format(time.Kitchen)) | |||
| state.Message = fmt.Sprintf("%s due to application controller sync timeout. Retrying attempt #%d at %s.", state.Message, state.RetryCount, retryAt.Format(time.Kitchen)) | |||
There was a problem hiding this comment.
Revisiting this after the refactor to this method on master. It seems like it is adding "due to application controller sync timeout." to every failures, even the ones unrelated to the timeout.
6 tasks
enneitex
pushed a commit
to enneitex/argo-cd
that referenced
this pull request
Aug 24, 2025
…ontroller sync timeout (argoproj#23657) Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com> Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI message was misleading when an operation was terminated due to a controller sync timeout, and there were pending retries.
I'm improving the message to explain to the user why the operation was terminated, as we do in other cases - Attaching also images after the change
Eventually, the UI will be like this when all retries have been completed
Checklist:
Closes #23523