Skip to content

fix(docs): fix applicationsetcontroller.enable.github.api.metrics to false in docs cm #23516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

fix(docs): fix applicationsetcontroller.enable.github.api.metrics to false in docs cm #23516

merged 1 commit into from
Jun 22, 2025

Conversation

reggie-k
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@reggie-k
fix docs
dcb76f2 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k reggie-k requested review from a team as code owners June 22, 2025 13:59
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jun 22, 2025 •
edited
Loading

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@reggie-k reggie-k enabled auto-merge (squash) June 22, 2025 14:04
@reggie-k reggie-k merged commit 614c85c into argoproj:master Jun 22, 2025
22 checks passed
reggie-k added a commit to codefresh-io/argo-cd that referenced this pull request Jun 22, 2025
@reggie-k
fix(docs): fix applicationsetcontroller.enable.github.api.metrics to …
07087b9 
…false in docs cm (argoproj#23516)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
reggie-k added a commit to codefresh-io/argo-cd that referenced this pull request Jun 23, 2025
@reggie-k @andrii-korotkov-verkada
feat: Add GitHub API metrics (#404)
be8d97d 
* added github api metrics

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

* fix(docs): fix applicationsetcontroller.enable.github.api.metrics to false in docs cm (argoproj#23516)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>

* fix: Account for batch event processing in e2e tests (argoproj#22356)

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>

---------

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Co-authored-by: Andrii Korotkov <137232734+andrii-korotkov-verkada@users.noreply.github.com>
cjcocokrisp pushed a commit to cjcocokrisp/argo-cd that referenced this pull request Jun 24, 2025
@reggie-k @cjcocokrisp
fix(docs): fix applicationsetcontroller.enable.github.api.metrics to …
5eab52c 
…false in docs cm (argoproj#23516)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@reggie-k @enneitex
fix(docs): fix applicationsetcontroller.enable.github.api.metrics to …
a6c13d7 
…false in docs cm (argoproj#23516)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Mangaal pushed a commit to Mangaal/argo-cd that referenced this pull request Sep 10, 2025
@reggie-k @Mangaal
fix(docs): fix applicationsetcontroller.enable.github.api.metrics to …
ff9d673 
…false in docs cm (argoproj#23516)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reggie-k @pasha-codefresh