fix(controller): impersonation with destination name (#23309) #23504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23504 +/- ##
=======================================
Coverage 60.25% 60.25%
=======================================
Files 344 344
Lines 59084 59084
=======================================
Hits 35600 35600
Misses 20611 20611
Partials 2873 2873 ☔ View full report in Codecov by Sentry. |
|
/cherry-pick release-3.0 |
|
/cherry-pick release-3.1 |
cjcocokrisp
pushed a commit
to cjcocokrisp/argo-cd
that referenced
this pull request
Jun 24, 2025
…argoproj#23504) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
enneitex
pushed a commit
to enneitex/argo-cd
that referenced
this pull request
Aug 24, 2025
…argoproj#23504) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #21189, app.Spec.Destination.Server is not guaranteed to be populated in controller code. You have to explicitly pull the
destCluster. Thankfully in this case the impacted function already has the cluster var available.Fixes #23309